{"componentChunkName":"component---node-modules-rocketseat-gatsby-theme-docs-core-src-templates-docs-query-js","path":"/code-style/OmnichainERC721Transfers-OES","result":{"data":{"mdx":{"id":"8fbdf2fe-0b4a-5611-8037-9d4db937b1c0","excerpt":"OES-01C: Optimization of Conditionals Type Severity Location Gas Optimization OmnichainERC721Transfers.sol:L34 ,  L43-L46 ,  L48-L51 Description: The…","fields":{"slug":"/code-style/OmnichainERC721Transfers-OES/"},"frontmatter":{"title":"OmnichainERC721Transfers Code Style Findings","description":"Contains all the findings that relate to code style on the contract codebase","image":null,"disableTableOfContents":null},"body":"var _excluded = [\"components\"];\n\nfunction _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }\n\nfunction _objectWithoutProperties(source, excluded) { if (source == null) return {}; var target = _objectWithoutPropertiesLoose(source, excluded); var key, i; if (Object.getOwnPropertySymbols) { var sourceSymbolKeys = Object.getOwnPropertySymbols(source); for (i = 0; i < sourceSymbolKeys.length; i++) { key = sourceSymbolKeys[i]; if (excluded.indexOf(key) >= 0) continue; if (!Object.prototype.propertyIsEnumerable.call(source, key)) continue; target[key] = source[key]; } } return target; }\n\nfunction _objectWithoutPropertiesLoose(source, excluded) { if (source == null) return {}; var target = {}; var sourceKeys = Object.keys(source); var key, i; for (i = 0; i < sourceKeys.length; i++) { key = sourceKeys[i]; if (excluded.indexOf(key) >= 0) continue; target[key] = source[key]; } return target; }\n\n/* @jsxRuntime classic */\n\n/* @jsx mdx */\nvar _frontmatter = {\n  \"title\": \"OmnichainERC721Transfers Code Style Findings\",\n  \"description\": \"Contains all the findings that relate to code style on the contract codebase\"\n};\nvar layoutProps = {\n  _frontmatter: _frontmatter\n};\nvar MDXLayout = \"wrapper\";\nreturn function MDXContent(_ref) {\n  var components = _ref.components,\n      props = _objectWithoutProperties(_ref, _excluded);\n\n  return mdx(MDXLayout, _extends({}, layoutProps, props, {\n    components: components,\n    mdxType: \"MDXLayout\"\n  }), mdx(\"h2\", {\n    \"id\": \"span-idoes-01coes-01c-optimization-of-conditionalsspan\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h2\",\n    \"href\": \"#span-idoes-01coes-01c-optimization-of-conditionalsspan\",\n    \"aria-label\": \"span idoes 01coes 01c optimization of conditionalsspan permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), mdx(\"span\", {\n    id: \"OES-01C\"\n  }, \"OES-01C: Optimization of Conditionals\")), mdx(\"table\", null, mdx(\"thead\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"thead\"\n  }, mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Type\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Severity\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Location\"))), mdx(\"tbody\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"tbody\"\n  }, mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"/reports/evergon-labs-onchain-data-containers-67586dec2e0f7500187d6bc9/appendix/finding-types#gas-optimization\"\n  }, \"Gas Optimization\")), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"img\", {\n    parentName: \"td\",\n    \"className\": \"o-severity o-informational\",\n    \"src\": \"https://omniscia.io/report-assets/informational.png\"\n  })), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/evergonlabs/ODC/blob/e712cb66013ac0ecf990a08d86e95fb7819e6afa/contracts/dataManagers/omnichain/ERC721/OmnichainERC721Transfers.sol#L34\"\n  }, \"OmnichainERC721Transfers.sol:L34\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/evergonlabs/ODC/blob/e712cb66013ac0ecf990a08d86e95fb7819e6afa/contracts/dataManagers/omnichain/ERC721/OmnichainERC721Transfers.sol#L43-L46\"\n  }, \"L43-L46\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/evergonlabs/ODC/blob/e712cb66013ac0ecf990a08d86e95fb7819e6afa/contracts/dataManagers/omnichain/ERC721/OmnichainERC721Transfers.sol#L48-L51\"\n  }, \"L48-L51\"))))), mdx(\"h3\", {\n    \"id\": \"description\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#description\",\n    \"aria-label\": \"description permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Description:\"), mdx(\"p\", null, \"The \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/evergonlabs/ODC/blob/e712cb66013ac0ecf990a08d86e95fb7819e6afa/contracts/dataManagers/omnichain/ERC721/OmnichainERC721Transfers.sol#L40-L61\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"OmnichainERC721Transfers::_update\")), \" implementation which is purpose-built for the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"OmnichainAddress\"), \" data type will redundantly apply several \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"if\"), \" conditionals which are guaranteed to be \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"true\"), \".\"), mdx(\"h3\", {\n    \"id\": \"example\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#example\",\n    \"aria-label\": \"example permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n    parentName: \"pre\",\n    \"className\": \"language-sol\",\n    \"metastring\": \"title=contracts/dataManagers/omnichain/ERC721/OmnichainERC721Transfers.sol highlight={7,17,21} lineNumbers=true lineOffset=27\",\n    \"title\": \"contracts/dataManagers/omnichain/ERC721/OmnichainERC721Transfers.sol\",\n    \"highlight\": \"{7,17,21}\",\n    \"lineNumbers\": \"true\",\n    \"lineOffset\": \"27\"\n  }, \"function _safeTransferFrom(address from, OmnichainAddress to, uint256 tokenId, bytes memory) internal {\\n    (uint32 chainId, ) = OmnichainAddresses.decode(to);\\n    ChainidTools.requireNotCurrentChain(chainId);\\n\\n    // Setting an \\\"auth\\\" arguments enables the `_isAuthorized` check which verifies that the token exists\\n    // (from != 0). Therefore, it is not needed to verify that the return value is not 0 here.\\n    address previousOwner = _update(to, tokenId, _msgSender());\\n    if (previousOwner != from) {\\n        revert ERC721IncorrectOwner(from, tokenId, previousOwner);\\n    }\\n}\\n\\nfunction _update(OmnichainAddress to, uint256 tokenId, address auth) internal virtual returns (address) {\\n    address from = _ownerOf(tokenId);\\n\\n    // Perform (optional) operator check\\n    if (auth != address(0)) {\\n        _checkAuthorized(from, auth, tokenId);\\n    }\\n\\n    if (from != address(0)) {\\n        // Clear approval. No need to re-authorize or emit the Approval event\\n        _approve(address(0), tokenId, address(0), false);\\n    }\\n\\n    _writeTransfer(from, to, tokenId);\\n\\n    (uint32 toChainId, ) = OmnichainAddresses.decode(to);\\n    address toAddressPlaceholder = address(uint160(toChainId));\\n\\n    emit Transfer(from, toAddressPlaceholder, tokenId);\\n\\n    return from;\\n}\\n\")), mdx(\"h3\", {\n    \"id\": \"recommendation\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#recommendation\",\n    \"aria-label\": \"recommendation permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise the referenced \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"if\"), \" branches to be omitted as the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"auth\"), \" argument is guaranteed to be non-zero whilst the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"from\"), \" argument would fail in the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"ERC721Transfers::_checkAuthorized\"), \" call if it were zero.\"), mdx(\"h3\", {\n    \"id\": \"alleviation-c6b23c23d8bcd8cce85049ad959cbd711a37126b\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#alleviation-c6b23c23d8bcd8cce85049ad959cbd711a37126b\",\n    \"aria-label\": \"alleviation c6b23c23d8bcd8cce85049ad959cbd711a37126b permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Alleviation (c6b23c23d8bcd8cce85049ad959cbd711a37126b):\"), mdx(\"p\", null, \"The Evergon Labs team evaluated this exhibit and stated that while they acknowledge the optimization in the code's current state, they intend the code to be compatible with future upgrades that introduce burn operations etc. and thus wish to remain flexible.\"), mdx(ViewDiffButton, {\n    repoUrl: \"https://github.com/evergonlabs/ODC\",\n    mainHash: \"e712cb66013ac0ecf990a08d86e95fb7819e6afa\",\n    fixHash: \"c6b23c23d8bcd8cce85049ad959cbd711a37126b\",\n    gitHubIssue: \"162\",\n    mdxType: \"ViewDiffButton\"\n  }));\n}\n;\nMDXContent.isMDXComponent = true;","headings":[{"depth":2,"value":"<span id=\"OES-01C\">OES-01C: Optimization of Conditionals</span>"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation (c6b23c23d8bcd8cce85049ad959cbd711a37126b):"}]}},"pageContext":{"slug":"/code-style/OmnichainERC721Transfers-OES/","prev":{"label":"FungibleTokenDO.sol (FTD-C)","link":"/code-style/FungibleTokenDO-FTD"},"next":{"label":"OmnichainIdentifiers.sol (OIS-C)","link":"/code-style/OmnichainIdentifiers-OIS"}}},"staticQueryHashes":["1954253342","2328931024","2501019404","973074209"]}